- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.9k
          Add DataViewSchema overloads to ConvertToOnnx
          #6449
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Codecov Report
 
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #6449      +/-   ##
==========================================
- Coverage   68.55%   68.49%   -0.06%     
==========================================
  Files        1170     1170              
  Lines      246977   246980       +3     
  Branches    25792    25792              
==========================================
- Hits       169303   169164     -139     
- Misses      70951    71075     +124     
- Partials     6723     6741      +18     
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 | 
| No idea why  | 
| I added a comment in the issue itself, but I'll add it here as well. So the call to Transform itself is a lazy call. Unless you get a cursor and start itterating over the data itself this call should basically be a NO-OP (not quite true as it does some validations and still sets up the pipeline, but no actual "processing" should take place). Are you seeing something that is showing its actually doing data processing there? | 
| /azp run | 
| Azure Pipelines successfully started running 2 pipeline(s). | 
| Actually the original issue is about more the need to convert an  However, the failed test case  | 
Fixes #6448