Skip to content

Conversation

@ericstj
Copy link
Member

@ericstj ericstj commented May 19, 2025

Attempting to update just OnnxRuntime to see if that repros the issue seen in #7457

Copilot AI review requested due to automatic review settings May 19, 2025 22:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MicrosoftMLOnnxRuntime version from 1.18.1 to 1.21.0 in an effort to reproduce the issue noted in the referenced pull request.

  • Updated OnnxRuntime version in Versions.props for testing compatibility.

@ericstj
Copy link
Member Author

ericstj commented May 19, 2025

Yeah, here's a customer report microsoft/onnxruntime#24579

@ericstj
Copy link
Member Author

ericstj commented May 19, 2025

Confirmed this is the cause of the problem. Blocked on microsoft/onnxruntime#24579

@ericstj ericstj closed this May 19, 2025
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.99%. Comparing base (b17e794) to head (e8dc311).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7469      +/-   ##
==========================================
- Coverage   69.00%   68.99%   -0.01%     
==========================================
  Files        1482     1482              
  Lines      273880   273880              
  Branches    28254    28254              
==========================================
- Hits       188983   188961      -22     
- Misses      77514    77533      +19     
- Partials     7383     7386       +3     
Flag Coverage Δ
Debug 68.99% <ø> (-0.01%) ⬇️
production 63.28% <ø> (-0.01%) ⬇️
test 89.46% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericstj ericstj reopened this Oct 29, 2025
@ericstj ericstj requested review from rokonec and tarekgh October 30, 2025 01:40
@ericstj
Copy link
Member Author

ericstj commented Oct 30, 2025

We expect Windows ARM64 tests to hang. Those helix queues are still down. The rest should be passing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant