-
Notifications
You must be signed in to change notification settings - Fork 3
Add remaining events from bypass #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was fast. Thanks!
a7d4ffe to
5977d0b
Compare
|
I think this is ready for some bashing, I didn't obsess much so there's likely still something wrong. |
b269b15 to
6864f7e
Compare
Before we could only use the ptrace probes in bypass mode, and for that we were abusing QQ_MEMFD, start peeling the stuff out of QQ_MEMFD so we can have it all outside bypass. PTRACE is pretty straightforward, we just bubble up what we get from the probes. ptrace
Pretty straightforward, don't bother saving allocations for strings like we do for QQ_FILE, this is a uber low volume event, so just allocate and save some code.
This enables all the shared memory related events outside of bypass under
QQ_SHM.
They were condensed into quark_shm{} since it fits quark better, to have on
event type by "subject".
Bugs
~~~~
MEMFD_OPEN's path is broken in the probe, so disable it.
SHMEM_OPEN is a bit buggy, a shmem_open(O_CREAT...) generates a file event
instead of a SHMEM_OPEN event, but an open on an existing one works.
#255
#256
7785709 to
bdffe76
Compare
This virtual mounts can have any arbitrary string in the first parameter, it's what it shows up on /proc/mounts as the first word. Our cgroup2 code is incorrectly looking at the first word of each line, instead of the third, see #257 RHEL 9.3 doesn't work for shmget. Since t_memfd and t_shm_open depend on QQ_FILE, also disable them where we know our file probes fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
commit bdffe76 (HEAD -> rem-events, origin/rem-events)
Author: Christiano Haesbaert haesbaert@elastic.co
Date: Wed Oct 29 15:28:42 2025 +0100
commit cefe5ff
Author: Christiano Haesbaert haesbaert@elastic.co
Date: Tue Oct 28 20:19:58 2025 +0100
commit c1e2f26
Author: Christiano Haesbaert haesbaert@elastic.co
Date: Tue Oct 28 11:57:21 2025 +0100
commit c7827c6
Author: Christiano Haesbaert haesbaert@elastic.co
Date: Tue Oct 28 09:18:54 2025 +0100