Require LiveView 1.0 at least

[crbelaus]

The ErrorTracker assets were compiled against an old (pre 1.0) version of LiveView. This causes issues in applications using LiveView 1.0 and newer.

[crbelaus]

@jaimeiniesta can you try if it fixes #158 for you?

[andreh11]

I have the same error in production and I can confirm that this PR fixes #158.

Also, I’d like to thank you for this wonderful project. If you need help, I’d be happy to contribute.

[jaimeiniesta]

@crbelaus sorry, I missed this notification.

I've tried this branch, and it does fix the issue for me. But now I see this error in the Firefox console:

LiveView asset version mismatch. JavaScript version 1.1.11 vs. server 1.1.13.
To avoid issues, please ensure that your assets use the same version as the server.
[error_tracker:1547:3872](http://localhost:4000/admin/error_tracker?)

[andreh11]

@jaimeiniesta Yes, I also see this error. @crbelaus, would you like some help to investigate this issue?

[crbelaus]

This is an interesting error. It seems to happen because the LiveView version used by the ErrorTracker does not match the one configured in the project that includes it.

I have to investigate it a bit deeper. There must be a way to ensure that LiveView does not complaint about different, but compatible versions.

[franc]

same same, but phoenix_live_view is now at 1.1.14

[crbelaus]

We may need to use the same approach as Oban Web did here. Basically we shouldn't bundle Phoenix and LiveView assets and, instead, we should read them at compile time and concatenate with our own app.js.

This would ensure that there is no version mismatch between the application's LiveView and the one bundled by the error tracker.

I'll try to work on this over the weekend.

EDIT: the Oban Web changes were in turn adapted from phoenixframework/phoenix_live_dashboard#386

[crbelaus]

The last commit should get rid of the warning about LiveView and ErrorTracker version mismatch. We now follow LiveDashboard and Oban Web footsteps and import the LiveView assets directly.

There is a potential separate improvement to ensure that the resulting assets can be cached properly. This was done in phoenixframework/phoenix_live_dashboard#406 and in oban-bg/oban_web@2b8f66b

Since this only affects the ErrorTracker dashboard I'll address it in a separate pull request to ensure that we don't delay support for Phoenix LiveView +1.0 any more.

Edit: @andreh11, @jaimeiniesta, @franc can you confirm that this fixes the warning for you as well?

[franc]

@crbelaus I can confirm that this removes the js version mismatch warning.
! thanks

[jaimeiniesta]

@crbelaus me too, there are no JS warnings now!

[codeadict]

I can confirm this works great now on liveview 1.1.2

[andreh11]

@crbelaus Thanks, working great now!