Update install.sh to support Pop!_OS #1809
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update install.sh to support PopOS
willmartian
changed the title
josevalim
reviewed
Oct 30, 2025
|
|
||
| id=$(grep '^ID=' /etc/os-release | cut -d '=' -f 2) | ||
| if [ "${id}" != ubuntu ]; then | ||
| if [[ "${id}" != ubuntu || "${id}" != pop ]]; then |
There was a problem hiding this comment.
Can you please test this version?
Suggested change
| if [[ "${id}" != ubuntu || "${id}" != pop ]]; then | |
| if [ "${id}" != ubuntu ] && [ "${id}" != pop ]; then |
We should fail if both do not match (the current version seems to support everything). And we should stick with sh instead of bash. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the quick install script to not exit early on Pop!_OS (based on Ubuntu). The script works (for me) after making this change.