Skip to content

Added single_intermediate_table option #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

Added single_intermediate_table option #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions embulk-output-jdbc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ Generic JDBC output plugin for Embulk loads records to a database using a JDBC d
- **retry_wait**: initial retry wait time in milliseconds (integer, default: 1000 (1 second))
- **max_retry_wait**: upper limit of retry wait, which will be doubled at every retry (integer, default: 1800000 (30 minutes))
- **mode**: "insert", "insert_direct", "truncate_insert", or "replace". See below (string, required)
- **single_intermediate_table**: Regardless of the mode, at most one intermediate table will be created. This is primarily used to avoid creating a large number of intermediate tables when there are a large number of input files. (boolean, default: false)
- **batch_size**: size of a single batch insert (integer, default: 16777216)
- **max_table_name_length**: maximum length of table name in this RDBMS (integer, default: 256)
- **default_timezone**: If input column type (embulk type) is timestamp, this plugin needs to format the timestamp into a SQL string. This default_timezone option is used to control the timezone. You can overwrite timezone for each columns using column_options option. (string, default: `UTC`)
Expand Down
8 changes: 6 additions & 2 deletions embulk-output-jdbc/src/main/java/org/embulk/output/jdbc/AbstractJdbcOutputPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ public interface PluginTask
@Config("mode")
public Mode getMode();

@Config("single_intermediate_table")
@ConfigDefault("false")
public boolean getSingleIntermediateTable();

@Config("batch_size")
@ConfigDefault("16777216")
// TODO set minimum number
Expand Down Expand Up @@ -693,7 +697,7 @@ private List<TableIdentifier> createIntermediateTables(final JdbcOutputConnectio
public List<TableIdentifier> call() throws Exception
{
intermTables = new ArrayList<>();
if (task.getMode().tempTablePerTask()) {
if (task.getMode().tempTablePerTask() && !task.getSingleIntermediateTable()) {
String tableNameFormat = generateIntermediateTableNameFormat(task.getActualTable().getTableName(), con, taskCount,
task.getFeatures().getMaxTableNameLength(), task.getFeatures().getTableNameLengthSemantics());
for (int taskIndex = 0; taskIndex < taskCount; taskIndex++) {
Expand Down Expand Up @@ -1078,7 +1082,7 @@ public TransactionalPageOutput open(TaskSource taskSource, Schema schema, final

// configure BatchInsert -> an intermediate table (!isDirectModify) or the target table (isDirectModify)
TableIdentifier destTable;
if (mode.tempTablePerTask()) {
if (mode.tempTablePerTask() && !task.getSingleIntermediateTable()) {
destTable = task.getIntermediateTables().get().get(taskIndex);
} else if (mode.isDirectModify()) {
destTable = task.getActualTable();
Expand Down