Property access benchmarking: timeit-based shell script #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwalton76
reviewed
Jun 28, 2020
| 10000 loops, best of 3: 144 usec per loop | ||
| Motor write speed_sp: | ||
| 1000 loops, best of 3: 1.08 msec per loop | ||
| ``` No newline at end of file |
There was a problem hiding this comment.
This looks pretty cool. I think some newlines in the output would help make it a little more readable but that is minor.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my take on a reproducible benchmark for property accesses. What do others think about this? I picked a few representative properties (mostly arbitrarily).
My hope is that we can then implement changes to the property access code and make reasonable decisions regarding perf regressions.