perf(urlencoded): move empty-body guard to avoid extra function closure #647
+4
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the URL-encoded body parsing by eliminating an extra function closure and moving the empty-body check directly into the parser function. The change improves performance by removing an unnecessary wrapper function while maintaining identical behavior.
- Moves empty-body guard from wrapper function to main parser function
- Eliminates extra function closure creation
- Changes
vartoconstfor the parser assignment
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| return function queryparse (body, encoding) { | ||
| return function parse (body, encoding) { | ||
| if (!body.length) return {} |
There was a problem hiding this comment.
The empty-body check !body.length may not handle all falsy cases correctly. Consider using !body || !body.length to handle cases where body might be null or undefined, ensuring consistent behavior with the original implementation.
Suggested change
| if (!body.length) return {} | |
| if (!body || !body.length) return {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlines the empty-body check into the parser returned by
createQueryParser, removing the extra wrapper function. The behavior is unchanged but we get a minor perf/alloc win by not creating a extra closure.