Skip to content

fix(sendStatus): prevent BigInt status codes #6839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(sendStatus): prevent BigInt status codes #6839

wants to merge 2 commits into from

Conversation

@Dhairya3391
Copy link

Summary

  • fix(sendStatus): add explicit BigInt validation
  • Prevents obscure TypeError when BigInt values are passed
  • Ensures consistency with existing status() validation

Test Plan

  • Added test cases for BigInt(200) and BigInt(999)
  • Verified all tests pass via npm test
  • Confirmed no regressions in existing functionality

Fixes #6756

shubhamdixit863
shubhamdixit863 reviewed Oct 16, 2025
View reviewed changes
@Dhairya3391
fix(sendStatus): prevent invalid numeric status codes
d715914 
Ensure status codes in sendStatus() are valid integers between 100-999, addressing PR feedback about oversized numeric values passing validation.
@krzysdz krzysdz mentioned this pull request Oct 16, 2025
Open
@abhisekp abhisekp mentioned this pull request Oct 22, 2025
Open
13 tasks
@abhisekp
Copy link

Likely a duplicate of #6758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@shubhamdixit863 shubhamdixit863 shubhamdixit863 left review comments

@anuragdaksh7 anuragdaksh7 anuragdaksh7 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

uncaught TypeError exception when using sendStatus with a BigNum

4 participants

@Dhairya3391 @abhisekp @shubhamdixit863 @anuragdaksh7