Update folly, fix USE_FOLLY_LITE #14071
Open
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Resolving this folly upgrade required fixing the FOLLY_LITE build with header include from the 'fmt' library. I was close to timing out on fixing USE_FOLLY_LITE and removing it altogether - it could be considered obsolete and/or not worth the maintenance cost. Test Plan: CI
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this in D85268833. |
jaykorean
reviewed
Oct 22, 2025
Makefile
Outdated
| perl -pi -e 's/memcpy.&ptr/memcpy((void*)&ptr/' third-party/folly/folly/lang/Exception.cpp | ||
| @# const mismatch | ||
| perl -pi -e 's/: environ/: (const char**)(environ)/' third-party/folly/folly/Subprocess.cpp | ||
| @# NOTE: boost source will be needed for any build including `USE_FOLLY_LITE` builds as those depend on boost headers |
There was a problem hiding this comment.
I guess we don't need to fetch fmt here?
There was a problem hiding this comment.
My local build apparently already had folly built from a full folly build.
And now I'm sure I would hit another CI failure if I just made the fix because of the new folly caching which does not hash the relevant makefile parts, so I'm going to arbitrarily change the folly git hash again :(
jaykorean
approved these changes
Oct 22, 2025
|
Well, that's concerning: |
|
@pdillinger oh wow. Should we file an issue for folly? |
It's more likely a rare race or UAF or something in our code, though I haven't been able to reproduce it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Resolving this folly upgrade required fixing the FOLLY_LITE build with header include from the 'fmt' library.
I was close to timing out on fixing USE_FOLLY_LITE and removing it altogether - it could be considered obsolete and/or not worth the maintenance cost.
Follow-up: make the folly build caching more friendly by hashing the relevant makefile parts. Not in this PR because then you wouldn't be able to see what changed in the folly build steps themselves.
Test Plan: CI