✨ Add support for reading configuration from pyproject.toml
#236
Conversation
patrick91
force-pushed
the
10-17-_add_support_for_reading_configuration_from_pyproject.toml
branch
5 times, most recently
from
404dc67 to
dd1e4df
Compare
patrick91
force-pushed
the
10-17-_add_support_for_reading_configuration_from_pyproject.toml
branch
from
dd1e4df to
b306a01
Compare
tiangolo
changed the title
pyproject.toml
tiangolo
left a comment
tiangolo
left a comment
There was a problem hiding this comment.
Awesome! 🚀
This is looking great. 🐔 🎉
I saw a small thing, but also left me thinking if we should or not add the host (and port).
| host=host, | ||
| port=port, | ||
| entrypoint=entrypoint, |
There was a problem hiding this comment.
It seems these host and port end up coming from the default values in the function definition, so they are never read from pyproject.toml 😅
I'm also wondering if we should add the host and port to the config. 🤔
With fastapi dev it defaults to localhost (127.0.0.1), with fastapi run it defaults to all hosts (0.0.0.0). Setting the host in the config would end up taking precedence over the defaults, which could be counterintuitive, e.g. someone tries to run it somewhere in prod and because they had an override in the file, it no longer listens to all the hosts.
I think I would suggest removing host from pyproject.toml.
About port, maybe it would make sense to allow changing it, in particular if they have multiple apps and want to run them all at the same time, but we don't support that yet in this file config. But maybe it's worth keeping it.
No description provided.