feat(forge): sync Config->EvmOpts, apply gas_limit and create2_deployer, add contract-level Env #12304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er, add contract-level Env
…er, add contract-level Env
sashass1315
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronize relevant Config fields into EvmOpts and EvmOpts::Env within TestRunnerConfig::reconfigure_with so that inline config updates (gas limits, memory, isolation, verbosity, create2 deployer, chain and block parameters) take effect. Apply gas_limit and create2_deployer in configure_executor to keep runtime aligned. Introduce configure_executor_env to apply the full Env only at contract level before setUp() runs, preventing function-level inline config from overriding environment changes made by setUp or cheatcodes. Update ContractRunner::apply_contract_inline_config to call configure_executor_env before configure_executor.