Skip to content

Conversation

@dipanshuhappy
Copy link
Contributor

Motivation

Resolves #12386

Solution

Passed poll-interval to provider client.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

mattsse
mattsse previously approved these changes Oct 30, 2025
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, unsure how ergonomic --poll-interval is but we can also introduce an alias

@mattsse
Copy link
Member

mattsse commented Oct 30, 2025

smol clippy suggestion

@dipanshuhappy
Copy link
Contributor Author

makes sense, unsure how ergonomic --poll-interval is but we can also introduce an alias

How does --pi sound as an alias ?

@dipanshuhappy
Copy link
Contributor Author

smol clippy suggestion

I have updated it with the clippy fix

grandizzy
grandizzy previously approved these changes Nov 2, 2025
@grandizzy
Copy link
Collaborator

@dipanshuhappy
Copy link
Contributor Author

Thank you, please fix the fmt, see https://github.com/foundry-rs/foundry/blob/master/CONTRIBUTING.md#resolving-an-issue

Yep I have ran those and pushed

@grandizzy
Copy link
Collaborator

Thank you, please fix the fmt, see https://github.com/foundry-rs/foundry/blob/master/CONTRIBUTING.md#resolving-an-issue

Yep I have ran those and pushed

thanks, clippy is good but fmt still fails

@dipanshuhappy
Copy link
Contributor Author

Thank you, please fix the fmt, see https://github.com/foundry-rs/foundry/blob/master/CONTRIBUTING.md#resolving-an-issue

Yep I have ran those and pushed

thanks, clippy is good but fmt still fails

Ah I didn't notice the fomatter error. Patched it now

@grandizzy grandizzy self-requested a review November 2, 2025 19:56
@grandizzy grandizzy enabled auto-merge November 2, 2025 19:56
@grandizzy grandizzy added this pull request to the merge queue Nov 2, 2025
Merged via the queue into foundry-rs:master with commit d693f64 Nov 2, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

feat(cast): allow custom tx receipt polling interval in cast send

3 participants