-
Notifications
You must be signed in to change notification settings - Fork 8
feat: logging in contract and non contract env #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
fails in tests: need to use relative import from crate |
Also I am on nightly. |
@ple1n please check CI, is failing, for this to be merged it has to pass CI https://github.com/freenet/freenet-stdlib/actions/runs/18464415199/job/52607791262?pr=39 |
|
I moved testing to examples. I dont think it can work in crate and outside the crate simultaneously. macro v1 cant do that. |
|
You can absolutetly use and test regular macros within the same crate, but even if that was not the case, you can use integration tests that will run the CI pipeline instead of examples. They just need to be defined before the tests or imported from a different module, proc_macros cannot be used within the same crate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could move the you example to integration tests instead.
|
so you are going to do it right? can we get this feature done asap. you can commit to my branch directly |
Is your PR, you have to do the changes. |
|
Actually just remove the example since is not doing any test really. |
|
Removed. |

No description provided.