Fix query create update json sanitize #7442
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During query update/create input json is not sanitized correctly. Two glaring issues are: 1. During update when `user_id` field is present in request have ability to reasign query to other user. 2. During create when `is_archived` field is present in request created query is both draft & archived at the same time. This commit resolves the issue with the use of projection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
The query
def post(self)methods did not sanitize input correctly, any user with modify access can update query owner whenuser_idis set (bug present during update/create) alsoupdated_atmight be not updated whenskip_updated_atis present and set to True. During update whenis_archivedis set to True, created query is both a draft and archived at the same time.How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)