-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Document global attributes #15279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cleptric
wants to merge
1
commit into
master
Choose a base branch
from
global-attributes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Document global attributes #15279
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,6 +52,63 @@ Data from all three scope types MUST be merged in a specific order before being | |
|
|
||
|  | ||
|
|
||
| ## Scope Methods | ||
|
|
||
| ### Setting Attributes | ||
|
|
||
| Users MUST be able to attach attributes to any scope using a dedicated method (e.g., `scope.setAttributes()` or `scope.setAttribute()`). These attributes follow the structure defined in the [Span Protocol](/sdk/telemetry/spans/span-protocol/#attribute-object-properties). | ||
|
|
||
| Attributes are key-value pairs where each value is an object containing: | ||
|
|
||
| - `type`: The data type (`"string"`, `"integer"`, `"double"`, or `"boolean"`) | ||
| - `value`: The actual attribute value, which MUST match the specified type | ||
| - `unit` (optional): The unit of measurement (e.g., `"ms"`, `"s"`, `"bytes"`, `"count"`, `"percent"`) | ||
|
|
||
| #### Example Usage | ||
|
|
||
| ```javascript | ||
| Sentry.getGlobalScope().setAttributes({ | ||
| "app.feature_flag.enabled": { | ||
| type: "boolean", | ||
| value: true | ||
| }, | ||
|
Comment on lines
+71
to
+74
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IMO we should allow for an API that allows for the SDK to infer the type for the user. Otherwise this becomes more annoying for the dynamic language sdks. The attributes API currently in logs doesn't allow for users to specify the type. |
||
| "app.session_duration": { | ||
| type: "integer", | ||
| value: 3600, | ||
| unit: "s" | ||
| } | ||
| }); | ||
| ``` | ||
|
|
||
| ```python | ||
| sentry_sdk.get_global_scope().set_attributes({ | ||
| "app.feature_flag.enabled": { | ||
| "type": "boolean", | ||
| "value": True | ||
| }, | ||
| "app.session_duration": { | ||
| "type": "integer", | ||
| "value": 3600, | ||
| "unit": "s" | ||
| } | ||
| }) | ||
| ``` | ||
|
|
||
| #### Method Signature | ||
|
|
||
| The method SHOULD accept a dictionary/map/object where: | ||
| - Keys are attribute names (strings) | ||
| - Values are attribute objects with `type`, `value`, and optionally `unit` properties | ||
|
|
||
| #### Behavior | ||
|
|
||
| - Attributes set on the global scope MUST be applied to all logs | ||
| - Attributes set on the isolation scope MUST be applied to all logs in that execution context | ||
| - Attributes set on the current scope MUST be applied only to the current log | ||
| - When the same attribute key exists in multiple scopes, the more specific scope's value takes precedence (current > isolation > global) | ||
|
|
||
| See [Span Protocol - Common Attribute Keys](/sdk/telemetry/spans/span-protocol/#common-attribute-keys) for a list of standard attributes and [Sentry Conventions](https://github.com/getsentry/sentry-conventions/) for the complete attribute registry. | ||
|
|
||
| ## Related Documents | ||
|
|
||
| This document provides a concise summary of the [Hub & Scope Refactoring](/sdk/miscellaneous/hub_and_scope_refactoring/), focusing on implementation details and expected features. The original document remains unchanged, offering additional historical context and migration strategies. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can be less strict here. If we allow for more types, we can cast complex types to string and still allow them to be set. I think this makes it an easier API for users to use, and feels very easy to transition from contexts.