Skip to content

Conversation

@limbonaut
Copy link
Collaborator

@limbonaut limbonaut commented Oct 23, 2025

DESCRIBE YOUR PR

In Godot SDK, update the before_send examples to use exception value instead of message for filtering error events.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Oct 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 23, 2025 6:08pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Oct 23, 2025 6:08pm

@codeowner-assignment codeowner-assignment bot requested a review from a team October 23, 2025 17:38
@cursor

This comment was marked as resolved.

@limbonaut
Copy link
Collaborator Author

In response to the cursor comment: get_exception_value() returns an empty string when no exception is present. Since Godot does not support nullable types, strings cannot hold null values.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Bundle Report

Changes will decrease total bundle size by 6 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js -6.46kB 1.0kB -86.59%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
static/fvSy5_w9wWpxLuiI8jMih/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/fvSy5_w9wWpxLuiI8jMih/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/oLXxk2UdYPGTn_LOaHvrF/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/oLXxk2UdYPGTn_LOaHvrF/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants