Skip to content

Conversation

@sfanahata
Copy link
Contributor

DESCRIBE YOUR PR

Related to #15312
Fixed broken links that the 404 linter didn't catch while it was broken.

On Devloper Docs

On user facing docs

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 29, 2025 0:09am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 29, 2025 0:09am

@sfanahata sfanahata mentioned this pull request Oct 24, 2025
16 tasks
### My Lambda function uses `import`

If you're using `import` syntax in your function and you're _not_ transpiling the code to CommonJS, follow the [ESM instructions](./install/esm-npm__v9.x).
If you're using `import` syntax in your function and you're _not_ transpiling the code to CommonJS, follow the [ESM instructions](./npm).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The "ESM instructions" link in index__v9.x.mdx incorrectly points to npm.mdx instead of the ESM-specific guide.
Severity: HIGH | Confidence: 0.98

🔍 Detailed Analysis

When users click the "ESM instructions" link in index__v9.x.mdx, they are directed to npm.mdx instead of esm-npm__v9.x.mdx. This occurs because the link was changed from [ESM instructions](./install/esm-npm__v9.x) to [ESM instructions](./npm). The npm.mdx guide primarily focuses on CommonJS setup, which can lead ESM users to follow incorrect instructions for their module system. A similar issue exists in layer__v8.x.mdx.

💡 Suggested Fix

Change the link [ESM instructions](./npm) in index__v9.x.mdx to [ESM instructions](./esm-npm__v9.x) to correctly direct users to the ESM-specific guide.

🤖 Prompt for AI Agent
Fix this bug. In docs/platforms/javascript/guides/aws-lambda/install/index__v9.x.mdx at
line 25: When users click the "ESM instructions" link in `index__v9.x.mdx`, they are
directed to `npm.mdx` instead of `esm-npm__v9.x.mdx`. This occurs because the link was
changed from `[ESM instructions](./install/esm-npm__v9.x)` to `[ESM
instructions](./npm)`. The `npm.mdx` guide primarily focuses on CommonJS setup, which
can lead ESM users to follow incorrect instructions for their module system. A similar
issue exists in `layer__v8.x.mdx`.

Did we get this right? 👍 / 👎 to inform future reviews.

@codecov
Copy link

codecov bot commented Oct 24, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.98MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/3Doz4V9ZU6hsOxjXdS2Lk/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/3Doz4V9ZU6hsOxjXdS2Lk/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/c-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/c-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%

@sfanahata sfanahata merged commit 969f7b9 into master Oct 29, 2025
13 checks passed
@sfanahata sfanahata deleted the fix-broken-links branch October 29, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants