-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(onboarding): Split rails onboarding doc into multiple files #102203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(onboarding): Split rails onboarding doc into multiple files #102203
Conversation
| replayOnboardingJsLoader, | ||
| crashReportOnboarding: crashReport, | ||
| feedbackOnboardingJsLoader, | ||
| profilingOnboarding: profiling(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: profiling() call in rails/index.tsx omits frameworkPackage, causing incomplete Rails profiling gem snippet.
Severity: HIGH | Confidence: 1.00
🔍 Detailed Analysis
The profiling() function in static/app/gettingStartedDocs/ruby/rails/index.tsx is invoked without the frameworkPackage parameter. This omission prevents the sentry-rails gem from being included in the generated profiling setup documentation for Rails, leading to incomplete installation instructions for users. The profiling() function in static/app/gettingStartedDocs/ruby/ruby/profiling.tsx conditionally adds the framework gem based on this parameter.
💡 Suggested Fix
Add frameworkPackage: 'sentry-rails' to the profiling() call in static/app/gettingStartedDocs/ruby/rails/index.tsx at line 17.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/app/gettingStartedDocs/ruby/rails/index.tsx#L17
Potential issue: The `profiling()` function in
`static/app/gettingStartedDocs/ruby/rails/index.tsx` is invoked without the
`frameworkPackage` parameter. This omission prevents the `sentry-rails` gem from being
included in the generated profiling setup documentation for Rails, leading to incomplete
installation instructions for users. The `profiling()` function in
`static/app/gettingStartedDocs/ruby/ruby/profiling.tsx` conditionally adds the framework
gem based on this parameter.
Did we get this right? 👍 / 👎 to inform future reviews.
Contributes to https://linear.app/getsentry/issue/TET-864/introduce-folders-for-onboarding-platforms