Skip to content

Conversation

@priscilawebdev
Copy link
Member

@linear
Copy link

linear bot commented Oct 28, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 28, 2025
@priscilawebdev priscilawebdev marked this pull request as ready for review October 29, 2025 07:34
@priscilawebdev priscilawebdev requested a review from a team as a code owner October 29, 2025 07:34
cursor[bot]

This comment was marked as outdated.

replayOnboardingJsLoader,
crashReportOnboarding: crashReport,
feedbackOnboardingJsLoader,
profilingOnboarding: profiling(),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: profiling() call in rails/index.tsx omits frameworkPackage, causing incomplete Rails profiling gem snippet.
Severity: HIGH | Confidence: 1.00

🔍 Detailed Analysis

The profiling() function in static/app/gettingStartedDocs/ruby/rails/index.tsx is invoked without the frameworkPackage parameter. This omission prevents the sentry-rails gem from being included in the generated profiling setup documentation for Rails, leading to incomplete installation instructions for users. The profiling() function in static/app/gettingStartedDocs/ruby/ruby/profiling.tsx conditionally adds the framework gem based on this parameter.

💡 Suggested Fix

Add frameworkPackage: 'sentry-rails' to the profiling() call in static/app/gettingStartedDocs/ruby/rails/index.tsx at line 17.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/gettingStartedDocs/ruby/rails/index.tsx#L17

Potential issue: The `profiling()` function in
`static/app/gettingStartedDocs/ruby/rails/index.tsx` is invoked without the
`frameworkPackage` parameter. This omission prevents the `sentry-rails` gem from being
included in the generated profiling setup documentation for Rails, leading to incomplete
installation instructions for users. The `profiling()` function in
`static/app/gettingStartedDocs/ruby/ruby/profiling.tsx` conditionally adds the framework
gem based on this parameter.

Did we get this right? 👍 / 👎 to inform future reviews.

@priscilawebdev priscilawebdev merged commit 8f58aa8 into master Oct 29, 2025
47 checks passed
@priscilawebdev priscilawebdev deleted the priscila/ref/onboarding/split-rails-onboarding-docs branch October 29, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants