Skip to content

ggml webgpu: minor set rows optimization #16810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

ggml webgpu: minor set rows optimization #16810

wants to merge 5 commits into from
+100 −29

Conversation

@reeselevine
Copy link
Collaborator

  • Better parallelization of SET_ROWS by having multiple threads work on each row, as well as vectorization
  • Adds more useful labels to buffers for debugging
  • Adds Dawn-specific toggles which disable some safety protections when running natively, for better performance

Better matrix multiplication coming soon!

reeselevine and others added 5 commits October 15, 2025 19:04
@reeselevine
Add buffer label and enable dawn-specific toggles to turn off some ch…
b566811 
…ecks
@neha-ha @reeselevine
Minor set_rows optimization (#4)
f2e187c 
* updated optimization, fixed errors

* non vectorized version now dispatches one thread per element

* Simplify

* Change logic for set_rows pipelines

---------

Co-authored-by: Neha Abbas <nehaabbas@macbookpro.lan>
Co-authored-by: Neha Abbas <nehaabbas@ReeseLevines-MacBook-Pro.local>
Co-authored-by: Reese Levine <reeselevine1@gmail.com>
@reeselevine
Merge remote-tracking branch 'upstream/master'
2aa05c6
@reeselevine
Comment on dawn toggles
51aae63
@reeselevine
Remove some comments
f0cfae4
@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ggml changes relating to the ggml tensor library for machine learning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reeselevine @neha-ha