CUDA: Remove unneded bias/gate dims in fused mmvq #16858
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pointed out [here](ggml-org#16847 (comment)) that only a single value is needed per target col per thread
JohannesGaessler
approved these changes
Oct 30, 2025
github-actions
bot
added
Nvidia GPU
Co-authored-by: Johannes Gäßler <johannesg@5d6.de>
ORippler
force-pushed
the
osimons/remove_unneded_bias_gate_dims
branch
from
c66a33d to
f79bd92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointed out
here that only a single value is needed per target col per thread