Skip to content

Conversation

@dingZvel
Copy link

@dingZvel dingZvel commented Nov 1, 2025

Exercise Review

Exercise Discussion

#94

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
  • Have you written unit tests using repo-smith to validate the exercise grading scheme?
  • Have you tested the download script using test-download.sh?
  • Have you verified that this exercise does not already exist or is not currently in review?
  • Did you introduce a new grading mechanism that should belong to git-autograder?
  • Did you introduce a new dependency that should belong to app?

@dingZvel
Copy link
Author

dingZvel commented Nov 1, 2025

I'm not sure what to do when there's a conflict in repo names, i.e., the user already has a repo named samplerepo-preferences. We could ask the user for a new name to rename the fork (using gh repo fork --fork-name).
The gh fork command automatically creates the fork with the name samplerepo-preferences-1 if there's a conflict, and for now I just leave the repo name as is.

@damithc
Copy link
Contributor

damithc commented Nov 1, 2025

I'm not sure what to do when there's a conflict in repo names, i.e., the user already has a repo named samplerepo-preferences. We could ask the user for a new name to rename the fork (using gh repo fork --fork-name).
The gh fork command automatically creates the fork with the name samplerepo-preferences-1 if there's a conflict, and for now I just leave the repo name as is.

We can use an alternative fork name such as samplerepo-preferences-1 but in that case we should inform the user about it.
On a related note, GitHub does not allow us to fork the same repo twice. If the user already has a fork of this repo, we may have to abort the operation and inform the user about the conflict e.g., ask the user to delete the fork and run the download operation again.

@dingZvel
Copy link
Author

dingZvel commented Nov 1, 2025

We can use an alternative fork name such as samplerepo-preferences-1 but in that case we should inform the user about it. On a related note, GitHub does not allow us to fork the same repo twice. If the user already has a fork of this repo, we may have to abort the operation and inform the user about the conflict e.g., ask the user to delete the fork and run the download operation again.

Sure! Maybe I can submit follow-up commits regarding this later.

@damithc damithc linked an issue Nov 2, 2025 that may be closed by this pull request
@dingZvel
Copy link
Author

dingZvel commented Nov 2, 2025

The follow-up commits are up!
Now it aborts the operation when the user already has a fork, and warns the user when there's a conflict in repo name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Hands-On Discussion] T4L2/hp-push-tags (Pushing tags to a remote)

2 participants