Update tab title when navigating file tree #35757
Open
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
silverwind
approved these changes
Oct 27, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Oct 27, 2025
Comment on lines
+46
to
+51
| buildTitle(oldTreePath: string, treePath: string) { | ||
| // the title always starts with "<repoName>/<treePath>" | ||
| const oldPrefixLength = props.repoName.length + 1 + oldTreePath.length; | ||
| const titleSuffix = document.title.substring(oldPrefixLength); | ||
| return `${props.repoName}/${treePath}${titleSuffix}`; | ||
| }, |
There was a problem hiding this comment.
That's really fragile.
I think backend can fully prepare the "title" (ctx.Data["Title"]), pass it to frontend, and frontend only needs to set it.
There was a problem hiding this comment.
The title can be passed from backend to frontend by a HTML attribute, then in loadViewContent, read the title attribute and set it to the current document's title.
By the way, the URL handling in loadViewContent seems also not quite right, could be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #35749.