FIX: Update cli_deploy.py to solve cloud run deploy error in Windows

[jlightfoot]

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

• Closes: Trouble deploying agent to cloud run. #1739
• Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
When running this command in Anaconda environment in Windows : 'adk deploy cloud_run --project=$GOOGLE_CLOUD_PROJECT -region=$GOOGLE_CLOUD_LOCATION $AGENT_PATH', deployment fails with Deploy failed: [WinError 2] The system cannot find the file specified

Solution:
Specifying shell=True to subprocess command call solves the issue

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

• I have added or updated unit tests for my change.
• All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

• I have read the CONTRIBUTING.md document.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.
• I have manually tested my changes end-to-end.
• Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

[gemini-code-assist]

Summary of Changes

Hello @jlightfoot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical deployment failure for Windows users attempting to deploy to Cloud Run using the adk CLI. Previously, these deployments would fail with a "WinError 2" due to how the gcloud command was executed. The change introduces shell=True to the subprocess.run call, allowing the system to correctly find and execute the necessary commands on Windows.

Highlights

• Windows Cloud Run Deployment Fix: Addresses a "WinError 2" encountered when deploying to Cloud Run from Windows environments, specifically within Anaconda, by ensuring the gcloud command executes correctly.
• subprocess.run Parameter Update: The subprocess.run command in cli_deploy.py has been updated to include shell=True, which is necessary for proper command execution on Windows.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[adk-bot]

Response from ADK Triaging Agent

Hello @jlightfoot, thank you for creating this PR!

Could you please provide more details on how you manually tested this change, as requested in the Manual End-to-End (E2E) Tests section of the contribution guidelines? This could include the commands you used and the console output showing that the fix is effective.

Also, please consider adding or updating unit tests for your change and including a summary of the pytest results.

This information will help reviewers to review your PR more efficiently. Thanks!

[gemini-code-assist]

Code Review

This pull request addresses a deployment failure on Windows by adding shell=True to a subprocess.run call. While this fixes the issue, using shell=True unconditionally can introduce security risks and cause inconsistent behavior across different operating systems. My review includes a suggestion to apply this change only on Windows, which is a safer and more targeted approach.

[locphan2207]

I have tried applying this change to my local, but it does not seem to resolve the issue for me.