Document use case for environment variables CFL_* #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| page in OSS-Fuzz's `base-builder` image documentation for more details on | ||
| environment variables that are available to `build.sh`. | ||
|
|
||
| If some environment variables needs to be passed from your CI to the build, |
There was a problem hiding this comment.
Remind me please, where is the code that makes this true? I'm not sure this is correct
There was a problem hiding this comment.
Indeed, that was not correct cf https://github.com/google/oss-fuzz/blob/master/infra/cifuzz/config_utils.py#L69
There was a problem hiding this comment.
| - if: $MODE == "coverage" | ||
| before_script: | ||
| - export CFL_CONTAINER_ID=`cut -c9- < /proc/1/cpuset` | ||
| - export CFL_CONTAINER_ID=`docker ps -q -f "label=com.gitlab.gitlab-runner.job.id=$CI_JOB_ID" -f "label=com.gitlab.gitlab-runner.type=build"` |
There was a problem hiding this comment.
And why this change?
There was a problem hiding this comment.
completes commit e647b6c
There was a problem hiding this comment.
@securitykernel @catenacyber do you think this change is safe to make for gitlab users or will break some of them?
There was a problem hiding this comment.
Ping @securitykernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.