binder: Introduce server authorization strategy v2 #12398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdcormie
changed the title
jdcormie
force-pushed
the
isolated-process-3
branch
2 times, most recently
from
0b2d07f to
8d33b26
Compare
Moves the existing handshake logic behind an interface using the strategy pattern. No functional change.
jdcormie
force-pushed
the
isolated-process-3
branch
from
8d33b26 to
3ffbf7c
Compare
Adds support for android:isolatedProcess Services (fixing grpc#12293) and moves all peer authorization checks to the handshake, allowing subsequent transactions to go unchecked.
jdcormie
force-pushed
the
isolated-process-3
branch
from
3ffbf7c to
9c52e3d
Compare
jdcormie
added a commit
that referenced
this pull request
Oct 27, 2025
…12445) Avoids waiting for the handshake timeout on the server side in this case. I also add test coverage for the `!setOutgoingBinder()` case to make sure it works in the new location. My ulterior motive for this change is simplifying the client handshake code in preparation for #12398 -- An (impossible) !isShutdown() clause goes away for easy to understand reasons and I'll no longer have to pass the server's binder as an arg from async function to function in two separate handshake impls. Fixes #12438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
android:isolatedProcessServices (fixing #12293) and moves all security checks to the handshake, making subsequent transactions more efficient.