Skip to content

Conversation

@jdcormie
Copy link
Member

Accomplish this by splitting out the linkToDeath() part of setOutgoingBinder().

Also add a test for the DOA case and document why ignoring errors from linkToDeath() is ok.

Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not change BinderServer?

          BinderServerTransport transport =
              new BinderServerTransport(...);
          transport.setOutgoingBinder(callbackBinder, executor);
          transprot.start(listener.transportCreated(transport));

(Alternatively, create a factory method to call instead of the constructor.)

@jdcormie
Copy link
Member Author

(Alternatively, create a factory method to call instead of the constructor.)

done

@jdcormie jdcormie force-pushed the unify-doa-handling branch 2 times, most recently from 6e7d5d9 to 5a29d7a Compare October 31, 2025 05:38
Also add a test for the DOA case and document why ignoring errors from setOutgoingBinder() is ok.
@jdcormie jdcormie changed the title Stop leaking this from BinderServerTransport's ctor Two changes to setOutgoingBinder() (will not squash) Oct 31, 2025
@jdcormie jdcormie changed the title Two changes to setOutgoingBinder() (will not squash) Stop leaking this from BinderServerTransport's ctor Oct 31, 2025
@jdcormie jdcormie changed the title Stop leaking this from BinderServerTransport's ctor Stop leaking this from BinderServerTransport's ctor Oct 31, 2025
@jdcormie jdcormie merged commit 89d77e0 into grpc:master Oct 31, 2025
16 of 17 checks passed
@jdcormie jdcormie deleted the unify-doa-handling branch October 31, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants