Apply _existing_ code format to codebase #1340
Open
+1,964
−1,216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihsandemir
requested changes
Oct 23, 2025
| SELECT * FROM %1% | ||
| )") % map_name).str() }; | ||
| )") % map_name) | ||
| .str() }; |
There was a problem hiding this comment.
this format looks weird to me.
There was a problem hiding this comment.
It's just applying the output of the existing formatter. We should consolidate the code to a single format first and then we can tweak the formatter if required.
There was a problem hiding this comment.
@ihsandemir are we able to move anywhere on this?
| SELECT * FROM %1% | ||
| )") % map_name).str() }; | ||
| )") % map_name) | ||
| .str() }; |
| 4, 33, 0, 0, 0, 0, 0, | ||
| 0, 0, 0, 0, 255, 255, 255, 255, 42, 0, 0, 0, 0, 0, | ||
| 0, 0, 210, 4, 0, 0, 5, 1, | ||
| 36, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #946 the codebase was reformatted for consistency, but as this was not enforced the codebase has drifted since then.
Reformatted with
scripts/format-all.sh.Post-merge actions: