Update link for connection security level help button #3927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a dedicated URL constant for the connection security level documentation and updates the connection security level block view to use this more specific link instead of the generic companion app docs URL.
- Added
companionAppConnectionSecurityLevelconstant with a URL pointing to the specific documentation page - Updated
ConnectionSecurityLevelBlockViewto reference the new specific documentation URL - Added test coverage for the new URL constant
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/Shared/Environment/AppConstants.swift | Added new companionAppConnectionSecurityLevel URL constant pointing to specific documentation |
| Sources/App/WebView/Views/ConnectionSecurityLevelBlock/ConnectionSecurityLevelBlockView.swift | Updated learnMoreLink to use the new specific URL constant instead of generic docs URL |
| Tests/App/AppConstants.test.swift | Added test assertion to verify the new URL constant value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3927 +/- ##
==========================================
+ Coverage 44.72% 46.00% +1.28%
==========================================
Files 232 238 +6
Lines 13911 13363 -548
==========================================
- Hits 6221 6147 -74
+ Misses 7690 7216 -474 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on home-assistant/companion.home-assistant#1247
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes