-
Couldn't load subscription status.
- Fork 321
Search Relative Time Queries #1305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 71e24da The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code ReviewCritical Issues✅ No critical issues found. Minor Observations
Positive Notes
Overall: Well-implemented feature with good architecture. The minor items above are suggestions, not blockers. |
E2E Test Results✅ All tests passed • 39 passed • 3 skipped • 298s
|
|
Would it make sense to toggle "Relative Time" off if the user selects an absolute time range from the "Time Range" or "Around a time" panels? Because once they do that, the time is no longer relative, right? Also a related side-note, to me the Relative Time toggle being where it is seems slightly confusing because it doesn't seem to have any impact on the "Time Range" or "Around a time" panels. It only really seems to impact the "Last N " buttons, but it is visually separated from them. |
|
One minor thing I notice is that the relative time switch state is not persisted when I share the URL, despite the relative live tailing behavior being persisted Screen.Recording.2025-10-28.at.8.57.33.AM.mov |
Thanks for a thorough QA, I appreciate the feedback! Edit: One of my tests is flaky - I need to investigate more... Feel free to do a second pass of the logic though 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Happy to re-review after any test fixes
|
@pulpdrew I believe I actually was able to fix the test yesterday - but I got a merge conflict I had to resolve which marked the review as stale. Mind re-approving? Nothing has changed. |



Adds "Relative Time" switch to TimePicker component (if relative time is supported by parent). When enabled, searches will work similar to Live Tail but be relative to the option selected.
Some notes:
Fixes HDX-2653