Introduce new Vm trait #924
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
force-pushed
the
vm_trait_new
branch
3 times, most recently
from
81f0d54 to
62fad87
Compare
ludfjig
added
the
kind/refactor
ludfjig
force-pushed
the
vm_trait_new
branch
17 times, most recently
from
1562f26 to
edc7f00
Compare
ludfjig
force-pushed
the
vm_trait_new
branch
4 times, most recently
from
f6337f9 to
350b8e0
Compare
ludfjig
requested review from
jprendes,
marosset,
simongdavies and
syntactically
as code owners
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR 2/3 in a bigger effort to remove duplicate code across drivers.
depends on #907 which must be merged first, will mark this PR as ready then
This PR introduces
Vmtrait. It's a minimal trait for common functionality of a minimal Vm. It abstracts over differences in kvm, mshv, whp. This traits only knows things like set/get registers, run, but nothing about guest functions or hyperlight specifics.HyperlightVmstruct. This is a struct that contains thedyn Vmabove, as well as things like guest_ptr, rsp, memory-regions, gdb connections, etc. You can think of this as replacing the previous Hypervisor trait (but now it's just 1 struct to avoid duplicate code). HyperlightVm knows about initialization, dispatching guest calls, gdb-debugging etc, guest-tracing, whichVmtrait doesn't.kill()without changing behaviorCloses #465, #904