Skip to content

Conversation

@shenberg
Copy link

We've been getting race conditions with the older cffi method because it creates the .so file in run time, so several forking processes overwrite eachothers' .so files.

I updated the library to use the cffi 1.0 API out-of-line mode which builds the .so file on package install instead of dynamically when it's loaded.

@yuvalbar
Copy link

👍

@yuvalbar
Copy link

@andrix Any chance to get this merged and issue a new version?

@martindurant
Copy link
Member

I can merge. By release, do you mean a git-tag, pypi, conda-forge or all three?

@yuvalbar
Copy link

@martindurant I mean git tag and pypi at least, so that we can pip install the new version

@martindurant
Copy link
Member

OK, I can do that probably this evening. @yuvalbar , @shenberg , I would appreciate if you had a moment to consider whether any of the pending PRs merit inclusion.

@martindurant martindurant merged commit 389b876 into intake:master Jan 28, 2018
@martindurant
Copy link
Member

@shenberg
Copy link
Author

Thanks!
#21 can be closed (setuptools is already used)
#30 can be closed (different PR was merged that made this change already)

#35 <-- I would say that should be a separate project using python-snappy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants