Add tests for Tag Repository and a mock webserver for Varnish integration tests #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmengler
force-pushed
the
integration-tests
branch
6 times, most recently
from
a56f949 to
b1fe592
Compare
schmengler
force-pushed
the
integration-tests
branch
from
b1fe592 to
8cd8259
Compare
wigman
reviewed
Nov 25, 2019
| $phpExecutableFinder = $objectManager->get(PhpExecutableFinder::class); | ||
| $mockServerCmd = $phpExecutableFinder->find() . ' ' . self::MOCK_SERVER_DIR . '/server.php'; | ||
| //the following needs Symfony Process >= 4.2.0 | ||
| // $this->mockServerProcess = Process::fromShellCommandline($mockServerCmd); |
wigman
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Still to do: