Skip to content

Исправил проблему с повторной загрузкой списка вопросов #297 #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Исправил проблему с повторной загрузкой списка вопросов #297 #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/features/questions/questions-list/QuestionsList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ const QuestionsList = () => {
const isCompactMode = useSelector(selectIsCompactModeToogle);

const questionsIds = useSelector(questionSelectors.selectIds);
const questionsAll = useSelector(questionSelectors.selectAll);

const scrollHandler = useCallback(
(e) => {
Expand Down Expand Up @@ -67,8 +68,10 @@ const QuestionsList = () => {
}, [deletedOnly, dispatch, favoritesOnly]);

useEffect(() => {
dispatch(fetchQuestions({ favoritesOnly, deletedOnly }));
}, [deletedOnly, dispatch, favoritesOnly]);
if (!questionsAll.length) {
dispatch(fetchQuestions({ favoritesOnly, deletedOnly }));
}
}, [deletedOnly, dispatch, favoritesOnly, questionsAll.length]);

const QuestionWrapper = isCompactMode ? Paper : React.Fragment;
const generatedTitle = generateTitle(deletedOnly, favoritesOnly);
Expand Down
2 changes: 1 addition & 1 deletion src/features/questions/questionsSlice.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ const questionsSlice = createSlice({
},

[resetQuestionsList]: (state) => {
questionsAdapter.removeAll(state);
// questionsAdapter.removeAll(state);

state.pagination.offset = 0;
state.pagination.totalQuestions = 0;
Expand Down