Skip to content

fix(select): add missing filled type styles #30755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: next
Choose a base branch
from
Open

fix(select): add missing filled type styles #30755

wants to merge 11 commits into from
+18 −4

Conversation

@joselrio
Copy link
Contributor

@joselrio joselrio commented Oct 27, 2025 •
edited
Loading

Issue number: resolves #

What is the current behavior?

  • Select text color was not according design
  • Fill solid type was missing the background color

What is the new behavior?

  • Added the expected color to the select text
  • Added missing background color variable to the fill solid type

Does this introduce a breaking change?

  • Yes
  • No

@joselrio joselrio requested a review from a team as a code owner October 27, 2025 17:28
@joselrio joselrio requested a review from ShaneK October 27, 2025 17:28
@vercel
Copy link

vercel bot commented Oct 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Oct 29, 2025 10:56pm

@joselrio joselrio requested review from BenOsodrac and removed request for ShaneK October 27, 2025 17:28
@github-actions github-actions bot added the package: core @ionic/core package label Oct 27, 2025
BenOsodrac
BenOsodrac requested changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@BenOsodrac BenOsodrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joselrio Looking at Figma, these seemed the expected tokens to use

joselrio and others added 2 commits October 28, 2025 13:07
@joselrio @BenOsodrac
Update core/src/components/select/select.ionic.scss
478d18b 
Co-authored-by: Bernardo Cardoso <32780808+BenOsodrac@users.noreply.github.com>
@joselrio @BenOsodrac
Update core/src/components/select/select.ionic.scss
001f4ab 
Co-authored-by: Bernardo Cardoso <32780808+BenOsodrac@users.noreply.github.com>
@joselrio joselrio changed the title fix(select): add missing fill solid styles fix(select): add missing filled solid styles Oct 28, 2025
@joselrio joselrio changed the title fix(select): add missing filled solid styles fix(select): add missing filled type styles Oct 28, 2025
brandyscarney
brandyscarney requested changes Oct 29, 2025
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solid background looks good, but I think you need to change the select-text when it has a value (has-value class).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney brandyscarney requested changes

@BenOsodrac BenOsodrac BenOsodrac approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@brandyscarney brandyscarney

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joselrio @brandyscarney @BenOsodrac @Ionitron