Skip to content

Conversation

@rsav
Copy link
Contributor

@rsav rsav commented Oct 31, 2025

No description provided.

@rsav rsav requested a review from msdemlei October 31, 2025 13:38
Copy link
Member

@molinaro-m molinaro-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the date, that should refere to the approval one, the other changes are simply formatting, so this is approved as soon as the date is set according to the comments

Makefile Outdated

# Publication date, ISO format; update manually for "releases"
DOCDATE = 2024-01-25
DOCDATE = 2025-10-31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 2025-10-20, the date of approval by Exec, doesn't matter if it is in the past

<date role="creation"> 2010-05-19 </date>
<date role="updated"> 2012-02-17 </date>
<version> 1.0 </version>
<date role="updated"> 2025-10-31 </date>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as in the Makefile: 2025-10-20

msdemlei
msdemlei previously approved these changes Oct 31, 2025
Copy link
Collaborator

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it is preferable to have formatting changes in a separate, "whitespace-only" commit to make it easier to read later diffs, but it's ok this way, too. Except for Marco's date fix, I'd say let's go.

Thanks!

Copy link
Member

@molinaro-m molinaro-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine! Thanks for fixing the REC date!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants