yesno_dialog #20
Draft
yesno_dialog #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of the new environment variable GIT_ASK_YESNO to support the recently implemented fallback in case unlink, rename or rmdir fail for files in use on Windows. The added dialog will present a yes/no question to the the user which will currently be used by the windows compat layer to let the user retry a failed file operation. Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>
"Question?" is maybe not the most informative thing to ask. In the absence of better information, it is the best we can do, of course. However, Git for Windows' auto updater just learned the trick to use git-gui--askyesno to ask the user whether to update now or not. And in this scripted scenario, we can easily pass a command-line option to change the window title. So let's support that with the new `--title <title>` option. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>
For additional GUI goodness. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>
git-gui's proposed command-line dialog script relies upon Tk 8.5'ish constructs and is incompatible with Tcl 9.0. This dialog is hand crafted from several widgets, while Tk provides tk_dialog that handles the need here, and is fully supported in Tk 8.6 and 9.0. So, let's switch to that. Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
|
I carry the js/ask-yesno topic in my testing tree only as a courtesy. I have no intent to move it forward, but would rather eject it if it hinders testing other topics on Tcl/Tk 9. I took it from gitgitgadget/git#358. Any improvements should be done there or submitted as PR here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tk provides tk_dialog that is compatible across 8.6 and 9.0 and handles git-gui--askyesno requirements. The latter is not compatible with Tk 9.0, so let's use tk_dialog.
Note: this is a single commit on top of js/ask-yesno, the latter is not merged to master. I'm leaving this as a draft, the commit should probably be cherry-picked, and as I'm not using g4w and experiencing the need for this dialog, more testing is needed that I cannot really provide. This does work for me on Linux invoked from the command line on Tcl 8.6, 8.7, and 9.0.