testutils: make gix dependency optional #7847
Open
+53
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
force-pushed
the
ig/testutils-without-git
branch
2 times, most recently
from
b8d7026 to
7cfebc3
Compare
martinvonz
reviewed
Oct 25, 2025
ilyagr
force-pushed
the
ig/testutils-without-git
branch
from
7cfebc3 to
eff671e
Compare
ilyagr
commented
Oct 25, 2025
There was a problem hiding this comment.
Thanks for taking a look, Martin!
I think this PR is getting close, though it is not done super-carefully. I may have left some low-lying fruit on the tree.
This PR does make testutils compile without git. While I still don't understand the problem with gix I described in the PR description, this PR does solve it.
It's also hard to make this PR careful; I added a review comment about one particularly confusing issue in lib/Cargo.toml. That issue might be independent of this PR, though.
ilyagr
force-pushed
the
ig/testutils-without-git
branch
from
eff671e to
0c71b1a
Compare
|
OK, I think this is ready to go. I've marked my conversations with Martin as resolved, but anyone can feel free to reopen them if there's more to be done. |
ilyagr
force-pushed
the
ig/testutils-without-git
branch
from
0c71b1a to
0e935c3
Compare
This makes it possible to use `testutils` without depending on all of `gix`. Users of testutils without the Git feature would currently either have to use the LocalBackend or provide their own replacement to `TestRepo`. `jj-lib`'s test still depend on Git. Both before and after this PR, `cargo test --no-build -p jj-lib --no-default-features` fails to compile. This seems like a difficult problem to address; this PR merely tries to not make the situation worse. **Motivation**: In at least one ERSC use-case, we'd like to use `testutils`, but the gix dependency makes tests crash with the following error: ``` [test] thread 'gitoxide.in_parallel.produce.0' panicked at code/...: [test] there is no reactor running, must be called from the context of a Tokio 1.x runtime ``` It's not clear to me why this happens (@davidbarsky claims to have an idea), but this PR seems like a good workaround that also decreases the amount of things we'd need to compile.
ilyagr
force-pushed
the
ig/testutils-without-git
branch
from
0e935c3 to
346dc09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit description.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)