Skip to content

val Proposal Implementation #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 6, 2025
Merged

val Proposal Implementation #39

merged 20 commits into from
Jan 6, 2025

Conversation

@TotalTechGeek
Copy link
Member

@TotalTechGeek TotalTechGeek commented Dec 9, 2024 •
edited
Loading

@coveralls
Copy link

coveralls commented Dec 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12637397260

Details

  • 175 of 198 (88.38%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.1%) to 91.975%
Changes Missing Coverage Covered Lines Changed/Added Lines %
legacy.js 70 74 94.59%
defaultMethods.js 86 105 81.9%
Files with Coverage Reduction New Missed Lines %
defaultMethods.js 1 89.2%
Totals Coverage Status
Change from base Build 12509330850: -1.1%
Covered Lines: 916
Relevant Lines: 953
💛 - Coveralls

@TotalTechGeek TotalTechGeek changed the title Separate out the val proposal val Proposal Implementation Dec 26, 2024
@TotalTechGeek
Add a simple optimization to inline chained val logic.
c197e74
@TotalTechGeek
disableInline not flagged properly in val, corrected.
d1a3b4a
@TotalTechGeek
Erase varTop buildState
75e096b
@TotalTechGeek
Add implementation for exists, and coalescing, and test suites for each
d9b89bd
@TotalTechGeek
Touch up coalesce test suite
4422db5
@TotalTechGeek
Remove the legacy methods from the default methods javascript file
5d8ab20
@TotalTechGeek
Merge remote-tracking branch 'origin/master' into proposal/val
3609975
@TotalTechGeek
Some of the rewrites made things mildly slower, so I looked for an op…
ddd886e 
…timization to speed things back up. I've added a micro-optimization for val/var, making things generally more performant.
@TotalTechGeek
Further improvements and optimizations (some carried over from the pr…
83f8b4d 
…ecision work)
@TotalTechGeek
Add annotation to work around exotic build issue...
2292bf9
@TotalTechGeek
Expand test suite
cf0ec8a
@TotalTechGeek
Commit one more test (I guess this guy didn't get added earlier)
2b22100
@TotalTechGeek
Switch more tests to val, make further optimizations.
e52f768
@TotalTechGeek TotalTechGeek merged commit db57dec into master Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TotalTechGeek @coveralls