Skip to content

Conversation

@ZippoLag
Copy link

Hi, I've come to believe that these changes are neccesary in order to properly serve these PWA-related files (namely, favicon.ico, manifest.json, and the build-generated service-worker.json, precache-manifest(...).js and asset-manifest.json.

If you reject this because there's a better way or I'm misinterpreting something (I'm pretty new to SW and PWA) please advise on how to proceed.

Thanks!

@mattfreire mattfreire added the good first issue Good for newcomers label Aug 24, 2019
@mattfreire
Copy link
Collaborator

Hi. The changes you've made are necessary if you plan to use Django to host your frontend files. From the discussion in the YouTube video I can see that merging this makes sense however, I believe it's better to deploy the frontend as a static site and deploy the Django app as a standalone API. That way you won't need to specify these settings in your Django app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants