support for binary files #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an optional argument to constructor to specify the mode argument to the file open command. Defaults to 'r', for backwards-compatibility. The specific use case this addresses is supporting binary-encoded encoded files by specifying the mode as 'rb'. While using this module to parse pcap files generated by Wireshark, I found this to be a necessary change.
Last commit accidentally checked in a debug change where I started the initial seek at the beginning of the file instead of the end. Restoring this to the end so that the only delta is just the binary support intended.
|
@kasun, I'd completely forgotten about this PR, but just noticed it's still open and has no merge conflicts. Please let me know if there's something that needs to be changed to accept this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional argument to constructor to specify the mode argument to the file open command. Defaults to 'r', for backwards-compatibility.
The specific use case this addresses is supporting binary-encoded encoded files by specifying the mode as 'rb'. While using this module to parse pcap files generated by Wireshark, I found this to be a necessary change.