btrfs-progs: docs: further improve space cache documentation #620
+29
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For the btrfs check option of clearing, indicate that - since it's actually a full removing - a new space cache may be generated on the next mount. - In the summary of the `clear_cache` mount option, don't mention that it rebuilds the cache, as the option itself is in principle only about the clearing and the rebuilding happens "automatically" (unless other options are used). - In the details mention, however that there is rebuilding unless prevented by mount option. - Remove the "if something has gone wrong", as the mount option would also remove the cache if nothing went wrong. Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
|
please wait with this one... there's more to come |
Strcturise the details more clearly by: - What it does/implications. - The different versions an their details. - What happens if both versions are present. - What happens with kernels that cannot use v2. - How each version can be disabled, cleared or removed. - Make it more clear that the default of "space cache v2" applies also if the option isn't given at all. Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
calestyo
force-pushed
the
further-improve-space-cache-documentation
branch
from
e94afc8 to
e8a471c
Compare
|
Correctly rebased on Is the old v1 then cleared or (as with |
kdave
force-pushed
the
devel
branch
3 times, most recently
from
af681f4 to
1628b2f
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
a8c6f08 to
34c5de3
Compare
kdave
force-pushed
the
devel
branch
5 times, most recently
from
5e02de0 to
adfc8a9
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
d21d383 to
77988fe
Compare
kdave
force-pushed
the
devel
branch
7 times, most recently
from
ff87660 to
89204e7
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
869b77c to
76f0670
Compare
kdave
force-pushed
the
devel
branch
6 times, most recently
from
ef43ce6 to
3eff852
Compare
kdave
force-pushed
the
devel
branch
4 times, most recently
from
dafafca to
5d47f58
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
bb6a159 to
0fb0189
Compare
kdave
force-pushed
the
devel
branch
3 times, most recently
from
0ad9c81 to
9c1d53d
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
5d51853 to
6ea7070
Compare
kdave
force-pushed
the
devel
branch
7 times, most recently
from
9551363 to
94c16d5
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
d82be5c to
25f665e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the btrfs check option of clearing, indicate that - since it's actually a full removing - a new space cache may be generated on the next mount.
In the summary of the
clear_cachemount option, don't mention that it rebuilds the cache, as the option itself is in principle only about the clearing and the rebuilding happens "automatically" (unless other options are used).In the details mention, however that there is rebuilding unless prevented by mount option.
Remove the "if something has gone wrong", as the mount option would also remove the cache if nothing went wrong.