Skip to content

Conversation

@josepdcs
Copy link

This pull request makes a targeted fix to the file watching logic in the providers/file/file.go file. The change ensures that the callback function receives the actual file system event object rather than nil, which allows consumers of the API to have more context about the event that triggered the callback.

File watching improvement:

  • Modified the Watch method in File to pass the actual event object to the callback instead of nil, providing more context to callback consumers.

@knadh
Copy link
Owner

knadh commented Oct 28, 2025

Looks good @josepdcs. Once you've test and confirm, we can merge.

@josepdcs
Copy link
Author

Hi @knadh
I confirm that it works, and I’ve also modified the TestWatchFile test by adding an assertion to verify that the event is present and not nil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants