Skip to content

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Oct 13, 2025

  • include a proxy endpoint that routes traffic to the node-server
  • reduce frontend nextjs image size to ~300MB

I'm hoping this supplements #6204

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@netlify
Copy link

netlify bot commented Oct 13, 2025

Deploy Preview for knative ready!

Name Link
🔨 Latest commit 408c237
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/690641301f28ad000867656f
😎 Deploy Preview https://deploy-preview-6444--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 13, 2025
@dprotaso dprotaso force-pushed the drop-port-forwarding branch from 52b1140 to fe2efe6 Compare October 14, 2025 14:44
@dprotaso dprotaso marked this pull request as ready for review October 14, 2025 14:44
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025
@knative-prow knative-prow bot requested review from nainaz and skonto October 14, 2025 14:44
@dprotaso dprotaso closed this Oct 14, 2025
@dprotaso dprotaso reopened this Oct 14, 2025
@dprotaso
Copy link
Member Author

re-opened so we get the github rate limit fix in main

Copy link
Member

@Leo6Leo Leo6Leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't finished it yet. Submitting for the first round of review.

Copy link
Member

@Leo6Leo Leo6Leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have finished most of the review, beside these comments, the rest looks good. I will be manually follow and run through the tutorial later to make sure content is accurate. Thanks @dprotaso !

@dprotaso
Copy link
Member Author

bump @Leo6Leo

@Leo6Leo
Copy link
Member

Leo6Leo commented Oct 23, 2025

https://github.com/dprotaso/knative-docs/blob/drop-port-forwarding/code-samples/eventing/bookstore-sample-app/solution/ML-bad-word-filter/func.yaml#L6

The registry route should be updated to dynamic, and use the one that's being provided by the user input.

Also the @sha hash in those func.yaml file seems like causing some errors in the func deploy process. I didn't manage to use func deploy to deploy those ML services. Will continue tmr or the day after.

@dprotaso
Copy link
Member Author

The registry route should be updated to dynamic, and use the one that's being provided by the user input.
Also the @sha hash in those func.yaml file seems like causing some errors in the func deploy process. I didn't manage to use func deploy to deploy those ML services. Will continue tmr or the day after.

Want do make those changes in a follow up?

@Leo6Leo
Copy link
Member

Leo6Leo commented Oct 24, 2025

@dprotaso #6471

The follow up issue has been created. Another review will be needed after the func issue being fixed.

Copy link
Member

@Leo6Leo Leo6Leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have successfully had the bookstore running up and working locally with all the new changes. Besides my 2 comments there, the rest looks good to me! Thanks @dprotaso


# Deploy the ML services
echo ""
echo "📦 Deploying the ML service: bad-word-filter..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export DOCKER_HOST=unix://$HOME/.docker/run/docker.sock is needed for me when using local KinD cluster. Otherwise, the following error prompt:

📦 Deploying the ML service: bad-word-filter...
Building function image
Error: cannot create docker client: docker/podman API not available
Possible causes:
  The docker/podman daemon is not running.
  The DOCKER_HOST environment variable is not set.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export DOCKER_HOST=unix://$HOME/.docker/run/docker.sock

That's not universal so I don't think we should tell people to do that. A requirement beforehand should be a 'working docker'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants