ci: add NBC docker publish workflow #650
Merged
+68
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
added
do-not-merge/work-in-progress
area/ci
google-oss-prow
bot
added
size/M
area/controller
noalimoy
force-pushed
the
feature/add_NBC_test_workflow
branch
from
ec3cfb4 to
2e8dcd1
Compare
|
/ok-to-test |
andyatmiami
suggested changes
Oct 31, 2025
Signed-off-by: noa limoy <nlimoy@redhat.com>
noalimoy
force-pushed
the
feature/add_NBC_test_workflow
branch
from
2e8dcd1 to
a6528e1
Compare
andyatmiami
approved these changes
Oct 31, 2025
There was a problem hiding this comment.
Thanks @noalimoy - good to finally be at a place to get this merged. appreciate your work!
Verified on fork:
- https://github.com/andyatmiami/kubeflow-notebooks/actions/runs/18974861378/job/54191622291
- note: small commit to point to my repo
Image available:
|
Thank you for the PR @noalimoy! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the GitHub Actions workflow responsible for building and publishing the NBC (notebooks conroller) Docker image from the kubeflow/kubeflow repository to the kubeflow/notebooks repository.
related #615
Successfully built and published a test image:
GitHub Action Run