fix(l2): fix ethrex-l2-common crate compilation

[ilitteri]

Motivation

ethrex-l2-common needs for the SP1 and RISC0 guests' ELF to exist to compile. guest_program generates said ELFs in its build.rs, but as ethrex-l2-common, it's compiled before the build.rs runs, causing a compilation error.

Description

• Embed SP1 guest program in the guest_program crate.
• Move logic that needs said ELFs to the sequencer (who isn't a dependency from the guest_program crate).
• Remove sp1 and risc0 features from ethrex-l2-common as they are not needed anymore.

[Copilot]

Pull Request Overview

This PR refactors the handling of ZKVM program ELF files by centralizing their definitions in the guest_program module and removing the redundant logic from the common crate. The main goal is to simplify the codebase by eliminating duplicate ELF loading code and streamlining feature flag dependencies.

Key changes:

• Centralized ZKVM program ELF constants (ZKVM_SP1_PROGRAM_ELF, ZKVM_RISC0_PROGRAM_ELF) in the guest_program module
• Removed the aligned_vm_program_code() method from ProverType in the common crate and replaced it with direct ELF access in the sequencer
• Updated feature flag dependencies to propagate through the workspace more cleanly

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/l2/sequencer/l1_proof_sender.rs	Updated to directly access ZKVM ELF constants and added feature flag validation when sending proofs to Aligned Layer
crates/l2/prover/src/guest_program/src/lib.rs	Added ZKVM_SP1_PROGRAM_ELF constant definition with conditional compilation based on sp1 feature flag
crates/l2/prover/src/backend/sp1.rs	Updated to use centralized ZKVM_SP1_PROGRAM_ELF constant instead of local definition
crates/l2/common/src/prover.rs	Removed aligned_vm_program_code() method and associated constants, added documentation clarifying vk_path usage
crates/l2/common/Cargo.toml	Removed sp1 and risc0 feature flags from common crate
crates/l2/Cargo.toml	Added sp1 and risc0 feature flags that propagate to guest_program
cmd/ethrex/Cargo.toml	Removed ethrex-l2-common feature dependencies for sp1 and risc0

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Lines of code report

Total lines added: 47
Total lines removed: 55
Total lines changed: 102

Detailed view

+------------------------------------------------------+-------+------+
| File                                                 | Lines | Diff |
+------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/l2/deployer.rs                     | 1140  | +17  |
+------------------------------------------------------+-------+------+
| ethrex/crates/l2/common/src/prover.rs                | 128   | -50  |
+------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/src/backend/sp1.rs           | 126   | -5   |
+------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/src/guest_program/src/lib.rs | 12    | +8   |
+------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/l1_proof_sender.rs        | 434   | +22  |
+------------------------------------------------------+-------+------+

[ManuelBilbao]

Can't we delete this so?

[ilitteri]

I think the comment is misleading, that functionality is actually used by the deployer. Unless you meant to remove that from there and use it directly in the deployer bin.

[ManuelBilbao]

Yes, I the comment is confusing too. Maybe something like ...?

This function can be moved since it's used by the deployer but not the sequencer

[ilitteri]

I'll move the functionality there then.