Bug fix/currency selector dropdown #7015

darshitdudhaiya · 2025-10-09T22:38:30Z

Description

This PR fixes the sticky behavior of the currency dropdown in the Pricing page. The dropdown now scrolls smoothly with the page and no longer remains fixed when the user scrolls.

Notes for Reviewers

Verified that the dropdown menu moves correctly on scroll for all screen sizes.
Cleaned up MenuProps in the CurrencySelect component for better readability and maintainability.
Ensured that the dropdown styling and positioning remain consistent with the design.
No breaking changes to other components.

Signed commits

Yes, I signed my commits.

l5io · 2025-10-09T22:54:20Z

🚀 Preview for commit 38c616b at: https://68e83ca724b3759775a25244--layer5.netlify.app

darshitdudhaiya · 2025-10-10T05:07:34Z

@ChetanFTW can you review this PR and let me know if there is any changes needed.

l5io · 2025-10-10T12:16:07Z

🚀 Preview for commit 51950b9 at: https://68e8f8b59944789f89c5a596--layer5.netlify.app

ChetanFTW · 2025-10-10T12:55:28Z

you can check there is still sticky dropdown

darshitdudhaiya · 2025-10-10T18:27:42Z

you can check there is still sticky dropdown

sure i'll solve it.

github-actions · 2025-10-10T19:16:00Z

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

github-actions · 2025-10-10T19:17:09Z

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

l5io · 2025-10-10T19:33:39Z

🚀 Preview for commit 475bfac at: https://68e95f3e91eef310a44a31c0--layer5.netlify.app

l5io · 2025-10-10T21:05:12Z

🚀 Preview for commit 8af0a4f at: https://68e97472889a46abcad11ecc--layer5.netlify.app

Rajesh-Nagarajan-11

DCO Failing ⚠️ @darshitdudhaiya
To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~5 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin bug-fix/currency-selector-dropdown

Signed-off-by: Lakshay Pareek <hopesalive0291@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Signed-off-by: darshitdudhaiya <darshitdudhaiya201@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

… IntersectionObserver Signed-off-by: darshitdudhaiya <darshitdudhaiya201@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Signed-off-by: Divyanshi Pathak <divyanshipathakqc@mpgi.edu.in> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Introduced AGENTS.md as a universal standard for guiding AI coding agents, consolidating project context and configuration into a single file. Signed-off-by: Lee Calcote <lee.calcote@layer5.io> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Signed-off-by: Rasheedat Atinuke Jamiu <Hartinuke16@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Signed-off-by: Rasheedat Atinuke Jamiu <56790407+RashRAJ@users.noreply.github.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Signed-off-by: Darshit <92248308+darshitdudhaiya@users.noreply.github.com>

l5io · 2025-10-11T16:21:28Z

🚀 Preview for commit bf8e82c at: https://68ea83b00b2eebc1d36886bb--layer5.netlify.app

darshitdudhaiya · 2025-10-11T16:28:57Z

@ChetanFTW and @Rajesh-Nagarajan-11, can you please review this? I believe I have fully resolved the issue now.

Namanv0509 · 2025-10-13T09:40:30Z

@darshitdudhaiya
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

darshitdudhaiya · 2025-10-18T16:19:06Z

@darshitdudhaiya Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

Hey @Namanv0509 , I added it to the agenda after you mentioned it, but I see this PR hasn't been merged yet. Are there any problems or issues? I'm ready to complete it again if needed.

Rajesh-Nagarajan-11 · 2025-10-18T17:02:21Z

@darshitdudhaiya did you discuss this in meeting ? And get feedback on this PR

Rajesh-Nagarajan-11 · 2025-10-18T17:29:27Z

@ChetanFTW FYI

ChetanFTW · 2025-10-18T17:59:26Z

On Currency Dropdown is now responsive and LGTM
hey @Namanv0509 PTAL, I this PR the dropdown will automatically closed while overlapes widget and In my PR it will block the widgets until user make the section

darshitdudhaiya · 2025-10-18T18:43:40Z

@darshitdudhaiya did you discuss this in meeting ? And get feedback on this PR

No, I just added this as an agenda item in the meeting minutes.

Rajesh-Nagarajan-11 · 2025-10-27T11:27:40Z

Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT
Add it as an agenda item to the meeting minutes, if you would 😄

darshitdudhaiya · 2025-10-27T11:36:05Z

Thank you for your contribution! Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT Add it as an agenda item to the meeting minutes, if you would 😄

@Rajesh-Nagarajan-11 I've added it to the agenda and will try to join the website call today if possible.

leecalcote added the issue/dco Commit sign-off instructions label Oct 10, 2025

darshitdudhaiya force-pushed the bug-fix/currency-selector-dropdown branch from 475bfac to 8af0a4f Compare October 10, 2025 20:49

Rajesh-Nagarajan-11 reviewed Oct 11, 2025

View reviewed changes

Lakshay-Pareek and others added 18 commits October 11, 2025 21:34

Update mobile-swiper.style.js

5639952

Signed-off-by: Lakshay Pareek <hopesalive0291@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Update mobile-swiper.style.js

e29dc2b

Signed-off-by: Lakshay Pareek <hopesalive0291@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Update mobile-swiper.style.js

75cb3c1

Signed-off-by: Lakshay Pareek <hopesalive0291@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Update mobile-swiper.style.js

bc8c275

Signed-off-by: Lakshay Pareek <hopesalive0291@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Update mobile-swiper.style.js

9bb0aeb

Signed-off-by: Lakshay Pareek <hopesalive0291@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Update mobile-swiper.style.js

e8aa06c

Signed-off-by: Lakshay Pareek <hopesalive0291@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Update mobile-swiper.style.js

3c65d72

Signed-off-by: Lakshay Pareek <hopesalive0291@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Update mobile-swiper.style.js

ce6db17

Signed-off-by: Lakshay Pareek <hopesalive0291@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Update mobile-swiper.style.js

b37f109

Signed-off-by: Lakshay Pareek <hopesalive0291@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Add custom styles and properties to CurrencySelect menu for improved UX

710b78e

Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

fix: currency selector dropdown

64bae66

Signed-off-by: darshitdudhaiya <darshitdudhaiya201@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

feat: close CurrencySelect dropdown when it leaves the viewport using…

496baba

… IntersectionObserver Signed-off-by: darshitdudhaiya <darshitdudhaiya201@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

removed unused compponets and cleanup

fab7464

Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

Update Catalog Docs

aa62f51

Signed-off-by: Divyanshi Pathak <divyanshipathakqc@mpgi.edu.in> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

add image

93bb693

Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

hyphen

f739cf2

Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

quotes

a250441

Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

RashRAJ and others added 3 commits October 11, 2025 21:34

feat: add badges from layer5 cloud to recognition handbook

0094dcf

Signed-off-by: Rasheedat Atinuke Jamiu <Hartinuke16@gmail.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

fix: Update header for dark mode

bbd717a

Signed-off-by: Rasheedat Atinuke Jamiu <56790407+RashRAJ@users.noreply.github.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

fix: update project badges style

8c2caf0

Signed-off-by: Rasheedat Atinuke Jamiu <56790407+RashRAJ@users.noreply.github.com> Signed-off-by: Darshit Dudhaiya <darshitdudhaiya201@gmail.com>

darshitdudhaiya force-pushed the bug-fix/currency-selector-dropdown branch from 8af0a4f to 8c2caf0 Compare October 11, 2025 16:04

github-actions bot added area/blog New posts or new blog functionality area/handbook project/kanvas project/sistent labels Oct 11, 2025

Merge branch 'master' into bug-fix/currency-selector-dropdown

bf8e82c

Signed-off-by: Darshit <92248308+darshitdudhaiya@users.noreply.github.com>

darshitdudhaiya requested a review from Rajesh-Nagarajan-11 October 11, 2025 16:26

simihablo requested a review from Namanv0509 October 15, 2025 23:09

Uh oh!

Bug fix/currency selector dropdown #7015

Are you sure you want to change the base?

Bug fix/currency selector dropdown #7015

Conversation

darshitdudhaiya commented Oct 9, 2025

Uh oh!

l5io commented Oct 9, 2025

Uh oh!

darshitdudhaiya commented Oct 10, 2025

Uh oh!

l5io commented Oct 10, 2025

Uh oh!

ChetanFTW commented Oct 10, 2025

Uh oh!

darshitdudhaiya commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

l5io commented Oct 10, 2025

Uh oh!

l5io commented Oct 10, 2025

Uh oh!

Rajesh-Nagarajan-11 left a comment

Choose a reason for hiding this comment

Uh oh!

l5io commented Oct 11, 2025

Uh oh!

darshitdudhaiya commented Oct 11, 2025

Uh oh!

Namanv0509 commented Oct 13, 2025

Uh oh!

darshitdudhaiya commented Oct 18, 2025

Uh oh!

Rajesh-Nagarajan-11 commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rajesh-Nagarajan-11 commented Oct 18, 2025

Uh oh!

ChetanFTW commented Oct 18, 2025

Uh oh!

darshitdudhaiya commented Oct 18, 2025

Uh oh!

Rajesh-Nagarajan-11 commented Oct 27, 2025

Uh oh!

darshitdudhaiya commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Rajesh-Nagarajan-11 commented Oct 18, 2025 •

edited

Loading