-
Couldn't load subscription status.
- Fork 1.4k
Fix: Account menu dropdown closes when clicking outside #7074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@saurabhraghuvanshii Please review . |
|
🚀 Preview for commit 9b4d66c at: https://68fa4d8f60401d2726862e4d--layer5.netlify.app |
|
@rishiraj38 can you add loom video |
|
🚀 Preview for commit 3476077 at: https://68fa533e89280c0db39f6019--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that much of logic needed for it because on clicking icon it closing dropdown we have to handle only outside click.
3476077 to
d528dde
Compare
|
🚀 Preview for commit d528dde at: https://68fb1f909ae7487495f7707b--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a optimal way , just try to implement in simple way
Should I reuse the the NavBar components ? |
|
How can I optimise this? Using a timeout is increasing the time complexity, so I’d like some feedback on how to make it more optimal. |
Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
d528dde to
d4af2b4
Compare
|
🚀 Preview for commit d4af2b4 at: https://68fe36e4d22b696d3916038e--layer5.netlify.app |
|
Thank you for your contribution! |
Description
This PR fixes #7073
Previously, the account menu/dashboard dropdown remained open when clicking outside, which caused inconsistent behavior with the navbar.
Changes Made:
Signed commits