Skip to content

Conversation

@rishiraj38
Copy link
Contributor

@rishiraj38 rishiraj38 commented Oct 23, 2025

Description

This PR fixes #7073
Previously, the account menu/dashboard dropdown remained open when clicking outside, which caused inconsistent behavior with the navbar.

Changes Made:

  • Updated the account dropdown to appear on hover over the account section and disappear when the cursor leaves the area.
  • Behavior now matches the navbar dropdown for a consistent UX.
  • Removed the click-outside-to-close logic since hover behavior handles visibility naturally.

Signed commits

  • Yes, I signed my commits.

@rishiraj38
Copy link
Contributor Author

@saurabhraghuvanshii Please review .

@l5io
Copy link
Contributor

l5io commented Oct 23, 2025

🚀 Preview for commit 9b4d66c at: https://68fa4d8f60401d2726862e4d--layer5.netlify.app

@saurabhraghuvanshii
Copy link
Contributor

@rishiraj38 can you add loom video

@l5io
Copy link
Contributor

l5io commented Oct 23, 2025

🚀 Preview for commit 3476077 at: https://68fa533e89280c0db39f6019--layer5.netlify.app

Copy link
Contributor

@saurabhraghuvanshii saurabhraghuvanshii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that much of logic needed for it because on clicking icon it closing dropdown we have to handle only outside click.

@l5io
Copy link
Contributor

l5io commented Oct 24, 2025

🚀 Preview for commit d528dde at: https://68fb1f909ae7487495f7707b--layer5.netlify.app

Copy link
Member

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a optimal way , just try to implement in simple way

@rishiraj38
Copy link
Contributor Author

rishiraj38 commented Oct 24, 2025

This is not a optimal way , just try to implement in simple way

Should I reuse the the NavBar components ?

@rishiraj38
Copy link
Contributor Author

How can I optimise this? Using a timeout is increasing the time complexity, so I’d like some feedback on how to make it more optimal.

Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
@rishiraj38 rishiraj38 force-pushed the fix/account-dropdown-close branch from d528dde to d4af2b4 Compare October 26, 2025 14:43
@l5io
Copy link
Contributor

l5io commented Oct 26, 2025

🚀 Preview for commit d4af2b4 at: https://68fe36e4d22b696d3916038e--layer5.netlify.app

@Rajesh-Nagarajan-11
Copy link
Member

Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT
Add it as an agenda item to the meeting minutes, if you would 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: Account menu dropdown does not close when clicking outside

4 participants