[Remove Vuetify from Studio] Changing question type confirmation dialog in Questions #5514
+9
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisRob
reviewed
Oct 31, 2025
| v-if="dialog.open" | ||
| :title="dialog.title" | ||
| :cancelText="$tr('dialogCancelBtnLabel')" | ||
| :submitText="$tr('dialogChangeBtnLabel')" |
There was a problem hiding this comment.
I think we shouldn't lose the previous behavior dialog.submitLabel || $tr('dialogSubmitBtnLabel'). See how openDialog is used in AssessmentItemEditor (also please don't rename string keys - I believe we'd need to re-translate).
(It's possible that dialogs that utilize openDialog don't override Change string, but even if that'd be the case, I think it'd be useful to not remove the option to configure)
Same applies to cancel.
Please revisit other related place in this file.
There was a problem hiding this comment.
Ok @MisRob , I will make sure of what you mentioned
MisRob
changed the title
|
Could you also merge latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrated the
MessageDialogbuilt with several Vuetify components is currently used to show question type changing confirmation popup with KModal. The particular layer of code was implemented inAssesmentTab.vueScreenshots
The following is a visual of the new dialog built using KModal. The only major UI difference is that the title is not bold - this is the default behavior of KModal. To make it bold, custom CSS styling would need to be implemented within the file. If that’s needed, I’d be happy to make the change
…
References
Closes #5420
Reviewer guidance
How to reach there?