Use `lightning::util::anchor_channel_reserves` #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Camillarhi wants to merge 1 commit into lightningdevkit:main from Camillarhi:update-anchor-channel-reserve-estimation

Contributor

Camillarhi commented Oct 22, 2025

This update replaces the flat fee requirement for anchor channel reserves with a more accurate estimation using the new lightning::util::anchor_channel_reserves utility.

Integrated anchor_channel_reserves for dynamic reserve estimation
Removed flat static fee for anchors
Updated relevant logic and documentation to reflect the new estimation approach

Closes #668


          use lightning::util::anchor_channel_reserves for improved anchor re…

e7029bf

…serve estimation

Replaced flat fee-based reserve logic with estimation using
`get_reserve_per_channel`, following changes introduced in
lightningdevkit/rust-lightning#3487.

ldk-reviews-bot commented Oct 22, 2025 •

edited

Loading

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-reviews-bot requested a review from tnull

October 22, 2025 11:59

ldk-reviews-bot commented Oct 25, 2025

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Oct 27, 2025

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Oct 29, 2025

🔔 3rd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Nov 1, 2025

🔔 4th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Nov 3, 2025

🔔 5th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Nov 5, 2025

🔔 6th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Nov 8, 2025

🔔 7th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet